Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): bump official generator version to 7.9 #155

Closed
wants to merge 1 commit into from

Conversation

DmitrySboychakov
Copy link
Contributor

No description provided.

@gibahjoe gibahjoe added the cli label Nov 1, 2024
@DmitrySboychakov
Copy link
Contributor Author

Yet another update of generator
Please consider cutting a release after ;)

@gibahjoe
Copy link
Owner

gibahjoe commented Nov 4, 2024

Thank you for your contribution. However, I am moving away from including a jar in the library and will instead download the jar from a config specified by the user. You can find the code here

If you are not okay with this approach, please do let me know your reservations.

@DmitrySboychakov
Copy link
Contributor Author

@gibahjoe didn't read the code at a time, but agree 100% on that approach.
however, does it mean for enduser to have maven installed on the system?
if so, maybe it's better to handle that in the github actions instead?

@DmitrySboychakov
Copy link
Contributor Author

that being said, don't mind closing this PR at all.

@gibahjoe
Copy link
Owner

gibahjoe commented Nov 8, 2024

Sorry Just saw your comment.

No, the user does not have to have maven. The initial way didn't have to combine the multiple jars into a single jar, they could have been used as separate jars. I guess it was just easier having 1 jar instead of 2.

@gibahjoe
Copy link
Owner

gibahjoe commented Nov 8, 2024

That being said, v6.0.0 has been released.

Closing this in favor of #162

@gibahjoe gibahjoe closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants