Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows-color-fix: Changed foreground and background colors #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

welnanick
Copy link
Contributor

On windows, the 16 colors visible to the console map out like so:

0 -> backgroundColor
1 -> blue
2 -> green
3 -> cyan
4 -> red
5 -> magenta
6 -> yellow
7 -> lightWhite
8 -> lightBlack
9 -> lightBlue
10 -> lightGreen
11 -> lightCyan
12 -> lightRed
13 -> lightMagenta
14 -> lightYellow
15 -> foregroundColor

As you can see black (which maps to base02 in solarized) and white
(which maps to base2 in solarized) are not visible, meaning these colors
are missing on windows. To remedy this I changed the background colors
to base02 and foreground color to base2 to allow windows to use all 16
colors of solarized.

On windows, the 16 colors visible to the console map out like so:

    0 -> backgroundColor
    1 -> blue
    2 -> green
    3 -> cyan
    4 -> red
    5 -> magenta
    6 -> yellow
    7 -> lightWhite
    8 -> lightBlack
    9 -> lightBlue
    10 -> lightGreen
    11 -> lightCyan
    12 -> lightRed
    13 -> lightMagenta
    14 -> lightYellow
    15 -> foregroundColor

As you can see black (which maps to base02 in solarized) and white
(which maps to base2 in solarized) are not visible, meaning these colors
are missing on windows. To remedy this I changed the background colors
to base02 and foreground color to base2 to allow windows to use all 16
colors of solarized.
@welnanick
Copy link
Contributor Author

I am unable to test the effects this has on macOS and Linux machines. So I do not know if this breaks the theme for them.

Obviously this is not the most visually pleasant background and foreground choices, so if there was a way to only have these changed values when running on windows, that would probably be the best. I am not a Node.js programmer, so I don't know if that is possible or how to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant