convert_hf_to_gguf: fix typo #11377
Open
convert_hf_to_gguf: fix typo #11377
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing underscore to a layer_norm_epsilon parameter.
|
This is not a typo. Ref: https://huggingface.co/bigcode/octogeex/blob/main/config.json#L26 |
|
OK. That seems familiar (I saw this about a year ago and was rechecking this). But then I see layer_norm_epsilon everywhere else in the file. Out of curiosity, why isn't this consistent? I'd like to leave a note explaining this if everything is correct. Thx. |
|
Can you point out the line with layer_norm_epsilon? After changing, have you test it? We can't accept a PR without knowing it of work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing underscore to a layer_norm_epsilon parameter.