OpenGL ES3 backend #1510
Merged
OpenGL ES3 backend #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gordon-F
reviewed
Jun 20, 2021
kvark
force-pushed
the
gles
branch
2 times, most recently
from
55af9dd
to
8ba2771
Compare
Gordon-F
reviewed
Jun 24, 2021
Gordon-F
reviewed
Jun 24, 2021
| dst_target, | ||
| copy, | ||
| } => { | ||
| gl.bind_buffer(src_target, Some(src)); |
There was a problem hiding this comment.
WebGL related fix no longer required ?
There was a problem hiding this comment.
We'll probably need it, still. But at this point I'm basically re-implementing the backend, and I'm trying to focus on GLES3 first. After it lands, we'll follow up with fixes needed for WebGL2 specifically.
kvark
force-pushed
the
gles
branch
2 times, most recently
from
c86926f
to
af42298
Compare
bors bot
added a commit
that referenced
this pull request
Jun 27, 2021
1558: Update naga to 57b3256 r=kvark a=kvark **Connections** Needed for #1510 Picks up gfx-rs/naga#1039 **Description** Updates Naga to latest on Git. Refactors the use of `ResourceBinding` and Metal's binding map. **Testing** Examples. Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 27, 2021
1558: Update naga to 57b3256 r=kvark a=kvark **Connections** Needed for #1510 Picks up gfx-rs/naga#1039 and gfx-rs/naga#916 **Description** Updates Naga to latest on Git. Refactors the use of `ResourceBinding` and Metal's binding map. Also enables safe bound check handling on Vulkan (`Restrict` policy, cc @jimblandy). **Testing** Examples. Co-authored-by: Dzmitry Malyshau <[email protected]>
bors bot
added a commit
that referenced
this pull request
Jun 27, 2021
1558: Update naga to 57b3256 r=kvark a=kvark **Connections** Needed for #1510 Picks up gfx-rs/naga#1039 and gfx-rs/naga#916 **Description** Updates Naga to latest on Git. Refactors the use of `ResourceBinding` and Metal's binding map. Also enables safe bound check handling on Vulkan (`Restrict` policy, cc @jimblandy). **Testing** Examples. Co-authored-by: Dzmitry Malyshau <[email protected]>
cwfitzgerald
approved these changes
Jun 27, 2021
kvark
force-pushed
the
gles
branch
6 times, most recently
from
c60551b
to
037e317
Compare
This was referenced Jun 30, 2021
|
Filed #1574 for follow-up considerations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Follow-up to #1471
Description
The new wgpu-hal backend for GLES3
and WebGL2Edit: WebGL2 is not included here
Testing
Examples!
Current status: