Fix issues with specs again #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2514 +/- ##
===========================================
- Coverage 98.16% 69.75% -28.41%
===========================================
Files 128 125 -3
Lines 4849 4722 -127
===========================================
- Hits 4760 3294 -1466
- Misses 89 1428 +1339
|
solnic
force-pushed
the
solnic/fix-trap-spec
branch
from
2149910 to
30bac7e
Compare
This makes code loading so unstable that it makes no sense.
solnic
force-pushed
the
solnic/fix-trap-spec
branch
from
9da1c7a to
869ade2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This spec couldn't run reliably on multiple older rubies, couldn't run at all on jruby, and it would hang forever every now and then. So I fixed it here.
This also disables eager_load in sidekiq tests (we did the same thing in rails spec suite last year) as it causes VERY strange errors, this time it was send_event_job.rb causing all sorts of weird crashes with modules or methods being undefined, like this one:
#skip-changelog