Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Ruby 3.4; Upgrade actions workflows versions #2506

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

frederikspang
Copy link
Contributor

@frederikspang frederikspang commented Jan 1, 2025

Description

Describe your changes:

Upgrades tons of actions/checkout@v1 to v4, add 3.4 to build matrix.

Other questions: Ruby 2.4 is supported and tested, although it's EOL since 2020. Same goes for all versions through 3.0 actually, in yearly increments.

I'm all for keeping the test suite including some EOL versions, but 2.4 seems excessive.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.18%. Comparing base (ad535cc) to head (a278f36).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2506      +/-   ##
==========================================
- Coverage   98.20%   98.18%   -0.02%     
==========================================
  Files         128      128              
  Lines        4837     4839       +2     
==========================================
+ Hits         4750     4751       +1     
- Misses         87       88       +1     
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (ø)
sentry-rails 97.07% <100.00%> (ø)
sentry-sidekiq 97.02% <ø> (-0.41%) ⬇️
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/sentry/rails/backtrace_cleaner.rb 100.00% <100.00%> (ø)
...b/sentry/rails/tracing/active_record_subscriber.rb 96.36% <ø> (ø)
sentry-ruby/lib/sentry/backtrace.rb 96.72% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@solnic solnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We need to support ancient Rubies as long as Sentry customers use them 😅

@solnic solnic merged commit 7fe7f88 into getsentry:master Jan 2, 2025
@frederikspang
Copy link
Contributor Author

To be fair, as long as it's not an excessive work, it's fine!

We have a 2.7.x app running as well😄

@frederikspang frederikspang deleted the feature/upgrade-gh-actions branch January 2, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants