Use attempt_threshold to skip reporting on first N attempts #2503
+47
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for #1632.
I am bringing over the concept of
attempt_threshold
from Honeybadger.Retry counting is a bit tricky, and so I included a comment based on a GH comment from Honeybadger.
There are two relatively arbitrary decisions I made here that you should validate:
attempt_threshold
. Alternatively, we could skip until number of attempts is greater thanattempt_threshold
.Thanks for your consideration!