Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove usage of user segment #2493

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

feat: Remove usage of user segment #2493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
276a762
feat: Remove usage of user segment
AbhiPrasad Dec 11, 2024
b99d0d1
chore: Add changelog entry
AbhiPrasad Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
- Fix latency related nil error for Sidekiq Queues Module span data [#2486](https://github.com/getsentry/sentry-ruby/pull/2486)
- Fixes [#2485](https://github.com/getsentry/sentry-ruby/issues/2485)

### Internal

- Remove usage of user segment from baggage and dynamic sampling context propagation logic [#2493](https://github.com/getsentry/sentry-ruby/pull/2493)

## 5.22.0

### Features
Expand Down
1 change: 0 additions & 1 deletion sentry-ruby/lib/sentry/propagation_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ def populate_head_baggage
"environment" => configuration.environment,
"release" => configuration.release,
"public_key" => configuration.dsn&.public_key,
"user_segment" => @scope.user && @scope.user["segment"]
}

items.compact!
Expand Down
1 change: 0 additions & 1 deletion sentry-ruby/lib/sentry/transaction.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,6 @@ def populate_head_baggage
items["transaction"] = name unless source_low_quality?

user = @hub.current_scope&.user
items["user_segment"] = user["segment"] if user && user["segment"]

items.compact!
@baggage = Baggage.new(items, mutable: false)
Expand Down
Loading