Don't gate request query strings and form data behind send_default_pii #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/fix-rails-pii-params
branch
from
78c4fe5 to
f1c1f1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.0-dev #2452 +/- ##
===========================================
+ Coverage 97.94% 98.06% +0.12%
===========================================
Files 126 126
Lines 4714 4708 -6
===========================================
Hits 4617 4617
+ Misses 97 91 -6
|
sl0thentr0py
force-pushed
the
neel/fix-rails-pii-params
branch
3 times, most recently
from
55bbe4d to
ca51cc7
Compare
sl0thentr0py
force-pushed
the
neel/fix-rails-pii-params
branch
from
ca51cc7 to
c6d6137
Compare
|
The failing test seems to be about new behavior rails 7.2 and will be fixed separately |
|
Query strings should not be guarded by |
st0012
reviewed
Nov 25, 2024
| @@ -20,7 +20,7 @@ def record_sentry_breadcrumb(request_info, response_status) | |||
| level: :info, | |||
| category: self.class::BREADCRUMB_CATEGORY, | |||
| type: :info, | |||
| data: { status: response_status, **request_info } | |||
| data: { status: response_status, **request_info.compact } | |||
There was a problem hiding this comment.
IMO, this should be called at the caller's extract_request_info helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with behavior in other SDKs.
But since it changes behavior, we will release it as part of the next major.