Enforce latest rubygems on CI #2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2439 +/- ##
==========================================
+ Coverage 98.09% 98.17% +0.08%
==========================================
Files 126 126
Lines 4723 4723
==========================================
+ Hits 4633 4637 +4
+ Misses 90 86 -4
|
solnic
force-pushed
the
solnic/enfore-latest-rubygems-on-ci
branch
from
a9a0df5
to
3d7b004
Compare
solnic
force-pushed
the
solnic/enfore-latest-rubygems-on-ci
branch
from
d38090e
to
cb4492d
Compare
solnic
commented
Oct 19, 2024
| @@ -36,7 +36,7 @@ jobs: | |||
| - { ruby_version: 2.6, sidekiq_version: 5.0 } | |||
| - { ruby_version: 2.6, sidekiq_version: 6.0 } | |||
| - { ruby_version: jruby, sidekiq_version: 5.0 } | |||
| - { ruby_version: jruby, sidekiq_version: 6.0 } | |||
| - { ruby_version: jruby, sidekiq_version: 6.5 } | |||
There was a problem hiding this comment.
With latest rubygems under jruby, bundling sidekiq using 6.0 as the version spec would install sidekiq 6.0.x - and that version actually crashes with Sidekiq[]= not being defined error.
st0012
approved these changes
Oct 20, 2024
sl0thentr0py
pushed a commit
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that we use latest rubygems on CI. Without this we're seeing random failures caused by bugs in old Rubygems when bundling may crash with ArgumentError.
I discovered this through #2436 failing like that: https://github.com/getsentry/sentry-ruby/actions/runs/11411361838/job/31767045829?pr=2436#step:4:123
#skip-changelog