Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Sidekiq::JobRetry::Handled exception #2337

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

karlentwistle
Copy link
Contributor

@karlentwistle karlentwistle commented Jul 3, 2024

Adds Sidekiq::JobRetry::Handled exception to default Sidekiq ignore list.

Sidekiq::JobRetry::Skip exceptions are currently ignored, however, since Sidekiq 7.3.0 shipped, I think Sidekiq::JobRetry::Handled exceptions also need to be ignored.

You can see the full diff between 7.2.4..7.3.0 and I'd particularly like to draw your attention to the changes within lib/sidekiq/job_retry.rb.

You can see in certain scenarios Sidekiq now raises Sidekiq::JobRetry::Handled (7.3.0) instead of Sidekiq::JobRetry::Skip (7.2.4).

Without this change, some customers will see the following in their Sentry Issues after upgrading to Sidekiq 7.3.0.

Screenshot 2024-07-03 at 08 27 40

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (8e62859) to head (ebe45e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2337   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files         205      205           
  Lines       13479    13482    +3     
=======================================
+ Hits        13299    13302    +3     
  Misses        180      180           
Components Coverage Δ
sentry-ruby 99.03% <ø> (ø)
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.02% <100.00%> (+0.01%) ⬆️
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
sentry-sidekiq/lib/sentry/sidekiq/configuration.rb 100.00% <100.00%> (ø)
...-sidekiq/spec/sentry/sidekiq/configuration_spec.rb 100.00% <100.00%> (ø)

@natematykiewicz
Copy link

+1. I have a bunch of these in my Sentry as well, and they're always next to a second error event that's the actual problem. They can be safely ignored.

@karlentwistle karlentwistle force-pushed the ke/ignore-sidekiq-job-handled-exception branch from ebe45e4 to c3776b4 Compare October 18, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants