Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampled field to dynamic_sampling_context #2092

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Aug 17, 2023

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +9.43% 🎉

Comparison is base (8abb2d2) 73.82% compared to head (6ebd0d6) 83.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
+ Coverage   73.82%   83.25%   +9.43%     
==========================================
  Files          91      119      +28     
  Lines        4175     5674    +1499     
==========================================
+ Hits         3082     4724    +1642     
+ Misses       1093      950     -143     
Files Changed Coverage Δ
sentry-ruby/lib/sentry/transaction.rb 76.00% <ø> (ø)

... and 43 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@szokeasaurusrex szokeasaurusrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright

@st0012 st0012 added this to the 5.11.0 milestone Aug 20, 2023
@sl0thentr0py sl0thentr0py merged commit 86dfaea into master Aug 21, 2023
99 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/dsc-sampled branch August 21, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sampling Decision to Trace Envelope Header
4 participants