Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracing without performance #2084

Merged
merged 13 commits into from
Sep 1, 2023
Merged

Tracing without performance #2084

merged 13 commits into from
Sep 1, 2023

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Aug 2, 2023

This PR is 1/2 to enable Tracing without Performance, i.e. make sure all our events are connected even if they are not Transactions.

This enables use cases such as Errors / Transactions / Replays etc all being connected across services and not just Transactions.

Summary of changes

  • new PropagationContext class that generates trace/span ids and baggage irrespective of whether there are transactions/spans active or not
  • this lives on the Scope
  • three new top level methods that first check the span and fallback on the scope's propagation context
    • Sentry.get_traceparent
    • Sentry.get_baggage
    • Sentry.get_trace_propagation_headers
  • move dynamic_sampling_context to Event from TransactionEvent since all events will now have this info
  • use the new top level helpers in net/http patch to set propagation headers

closes #2056
also see #2089

@sl0thentr0py
Copy link
Member Author

@st0012 still gonna write some specs and test but feel free to start reviewing if you have time and let me know if you have questions on why we are doing this!

sentry-ruby/lib/sentry/propagation_context.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/propagation_context.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/event.rb Show resolved Hide resolved
sentry-ruby/lib/sentry/propagation_context.rb Show resolved Hide resolved
sentry-ruby/lib/sentry/hub.rb Outdated Show resolved Hide resolved
sentry-ruby/lib/sentry/propagation_context.rb Outdated Show resolved Hide resolved
@sl0thentr0py sl0thentr0py merged commit 9641957 into master Sep 1, 2023
95 of 97 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/twp branch September 1, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing without Performance
4 participants