Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test class namespaces #933

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

spawnia
Copy link
Contributor

@spawnia spawnia commented Jul 24, 2024

Fixes the namespaces of test classes to conform with PSR-4.

@cleptric cleptric requested a review from stayallive July 26, 2024 00:22
@stayallive
Copy link
Collaborator

Test suite is not liking this change.

@spawnia spawnia force-pushed the fix-test-namespaces branch from 4ec6a2a to a867da5 Compare July 31, 2024 08:01
@spawnia
Copy link
Contributor Author

spawnia commented Jul 31, 2024

Test suite is not liking this change.

I rebased atop the latest master. It seems like only some versions are failing, I don't really get why. Do you have an idea what could be going on?

@spawnia spawnia force-pushed the fix-test-namespaces branch from a867da5 to 1b76ce1 Compare September 23, 2024 13:06
@spawnia
Copy link
Contributor Author

spawnia commented Sep 23, 2024

Found and fixed the reason for the failing tests.

Copy link
Collaborator

@stayallive stayallive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, appreciate it, thanks!

@stayallive stayallive merged commit 8550265 into getsentry:master Sep 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants