Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Kotlin): Merge Kotlin and Kotlin Multiplaform into one #12302

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

kahest
Copy link
Member

@kahest kahest commented Jan 10, 2025

DESCRIBE YOUR PR

As discussed in #11848, we want to merge these to clean up the platforms landing page. KMP is now a (the only) sub-guide below Kotlin. The PR also adds a redirect for the KMP landing page.

Screenshot 2025-01-10 at 17 11 10

fixes #11848

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 4:28pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:28pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 4:28pm

Comment on lines -5 to -6
sdk: sentry.java
fallbackPlatform: java
Copy link
Member Author

@kahest kahest Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed to remove these, otherwise the KMP guide would use platform-includes from Java for some reason. in any case, removing this seems correct to me because it also removes the Java SDK info box on the right side which was confusing since we link to 3 different SDKs

Comment on lines +3366 to +3369
{
from: '/platforms/kotlin-multiplatform/',
to: '/platforms/kotlin/guides/kotlin-multiplatform/',
},
Copy link
Member Author

@kahest kahest Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict this only redirects this one page/route - in case there is a way to also redirect all sub-pages, please lmk

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 1.97kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 1.88kB (0.02%) ⬆️
sentry-docs-edge-server-array-push 366.84kB 94 bytes (0.03%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge Kotlin and Kotlin multiplaform into one
1 participant