-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Kotlin): Merge Kotlin and Kotlin Multiplaform into one #12302
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
sdk: sentry.java | ||
fallbackPlatform: java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed to remove these, otherwise the KMP guide would use platform-includes from Java for some reason. in any case, removing this seems correct to me because it also removes the Java SDK info box on the right side which was confusing since we link to 3 different SDKs
{ | ||
from: '/platforms/kotlin-multiplatform/', | ||
to: '/platforms/kotlin/guides/kotlin-multiplatform/', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict this only redirects this one page/route - in case there is a way to also redirect all sub-pages, please lmk
Bundle ReportChanges will increase total bundle size by 1.97kB (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
DESCRIBE YOUR PR
As discussed in #11848, we want to merge these to clean up the platforms landing page. KMP is now a (the only) sub-guide below Kotlin. The PR also adds a redirect for the KMP landing page.
fixes #11848
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
EXTRA RESOURCES