-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): re-publish docs on python unleash and generic integrations #12300
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 261 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
@@ -0,0 +1,49 @@ | |||
--- | |||
title: Generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make the title a little more descriptive here? Like 'Generic Feature Flags' or something like that? Same with the page title for 'Unleash', maybe 'Feature Flags using Unleash'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move generic integration documentation to platform/<language>/feature-flags
since the generic integration is going away. Ref: getsentry/sentry-python#3917
…o revert-12296-aliu/unpublish-unleash
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some smaller changes to push this over the finish line.
--- | ||
|
||
<PlatformContent includePath="feature-flags/prerelease-alert" /> | ||
|
||
A feature flagging integration allows you to manually track feature flag evaluations through an API. These evaluations are collected in memory, and in the event an error occurs, sent to Sentry for review and analysis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A feature flagging integration allows you to manually track feature flag evaluations through an API.
This isn't correct, the integrations automatically hook into the 3rd party SDK's evaluations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see this was copied from the integrations/feature-flags/ page, will correct
These docs were originally approved and published, but reverted in #12296 since the integrations aren't released, and won't be for at least a couple days.
This PR re-publishes them and
initialize_client()
) and versioning.flags
context into Scope sentry-python#3917Closes https://github.com/getsentry/team-replay/issues/516