-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale bot #2825
Add stale bot #2825
Conversation
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
.github/workflows/stale-bot.yaml
Outdated
steps: | ||
- uses: actions/stale@v8 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if getporter
has this but using this, this token would have to be set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @troy0820 thanks for the review. I took this from another yaml file in this project
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^ was gonna suggest that it be this
Co-authored-by: Troy Connor <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Let's set up some rules around closing issues, and we'll follow how the k8s stale bot does things. Bot should comment basically the same thing as the comment. I'll copy the comment so it's easier to see here:
(we can't don't have their triage for help or sigs so I removed those two bottom lines) replace kubernetes with porter and we should be g2g |
Heya! Just wanted to check in and see if there's any assistance I can provide to get this merged! Thank you again for all your work. |
Hi @schristoff just haven’t been feeling well. Will finish this off before this week ends. |
No rush of course, your health comes first (and work, family, all those other things!). Feel better soon! |
Just made some changes. I used the actions/stale workflow to compose together steps to handle the requirements for this bot. Now, I need to find a way to test it. |
@AGMETEOR Your DCO isn't set up again. Can you run |
a982db0
to
bd3168e
Compare
Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
This PR fixes the 'Understand the difference between imperative commands and desired state' Fixes: getporter#2820 Signed-off-by: Aviral Singh <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
* added .exe extension Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
fix link name and update deps Signed-off-by: Troy Connor <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
…ike `porter param show` (getporter#2824) * change printer for displayParam to display with list showing values like param show Signed-off-by: Troy Connor <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Arhell <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
added bundle name to command Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
* update hugo to v0.115.4 Signed-off-by: Arhell <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
* feat: Generating changelog.md using github actions! This PR will close down the issue getporter#2797 which will generate a chnagelog.md in the root repository of Porter when a release is published! fixes: getporter#2797 Signed-off-by: Aviral Singh <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
* added draft clarification for STATE and STATUS Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
bug: fix jq url in image --------- Signed-off-by: Sarah Christoff <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
* update all the things Co-authored-by: Troy Connor <[email protected]> Signed-off-by: schristoff <[email protected]> --------- Signed-off-by: Sarah Christoff <[email protected]> Signed-off-by: schristoff <[email protected]> Co-authored-by: Troy Connor <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Sarah Christoff <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Signed-off-by: Allan Guwatudde <[email protected]>
update OWNERS.md to include troy0820 as a maintainer Signed-off-by: Troy Connor <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
…2855) * (feat) Fix Unit Tests to pass on Windows Signed-off-by: Ludvig Liljenberg <[email protected]> --------- Signed-off-by: Ludvig Liljenberg <[email protected]> Signed-off-by: Allan Guwatudde <[email protected]>
Got sidetracked a bit. But I am back working on this week |
Signed-off-by: Allan Guwatudde <[email protected]>
…tale-bot Signed-off-by: Allan Guwatudde <[email protected]>
After many discussions, here's what we've decided on:
I'm closing this for now and I'm going to be opening a triaging issue :) |
What does this change
Introduces a stale bot that marks issues and PRs as stale after some time
What issue does it fix
Closes #2796
Notes for the reviewer
This implementation uses https://github.com/actions/stale .
We need to discuss certain things, like the text for the stale labels, after how long to mark as stale, close or leave PRs and issues open once they go stale?
Checklist
Reviewer Checklist