Merge pull request #1761 from carolynvs/hide-internal-outputs

Hide internal outputs from porter installation outputs list
getporter · Sep 17, 2021 · 09840b4 · 09840b4
2 parents a628df6 + 3864352
commit 09840b4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/porter/outputs.go b/pkg/porter/outputs.go
@@ -86,6 +86,11 @@ func NewDisplayValuesFromOutputs(bun cnab.ExtendedBundle, outputs claims.Outputs
 	displayOutputs := make(DisplayValues, 0, outputs.Len())
 	for i := 0; i < outputs.Len(); i++ {
 		output, _ := outputs.GetByIndex(i)
+
+		if bun.IsInternalOutput(output.Name) {
+			continue
+		}
+
 		do := &DisplayValue{Name: output.Name}
 		do.SetValue(output.Value)
 		schema, ok := output.GetSchema(bun)

diff --git a/pkg/porter/outputs_test.go b/pkg/porter/outputs_test.go
@@ -79,6 +79,10 @@ func TestPorter_PrintBundleOutputs(t *testing.T) {
 					"longfoo": &definition.Schema{
 						Type: "string",
 					},
+					"porter-state": &definition.Schema{
+						Type:    "string",
+						Comment: "porter-internal", // This output should be hidden because it's internal
+					},
 				},
 				Outputs: map[string]bundle.Output{
 					"foo": {
@@ -91,6 +95,10 @@ func TestPorter_PrintBundleOutputs(t *testing.T) {
 					"longfoo": {
 						Definition: "longfoo",
 					},
+					"porter-state": {
+						Definition: "porter-state",
+						Path:       "/cnab/app/outputs/porter-state.tgz",
+					},
 				},
 			}
 
@@ -100,6 +108,7 @@ func TestPorter_PrintBundleOutputs(t *testing.T) {
 			p.TestClaims.CreateOutput(r.NewOutput("foo", []byte("foo-output")))
 			p.TestClaims.CreateOutput(r.NewOutput("bar", []byte("bar-output")))
 			p.TestClaims.CreateOutput(r.NewOutput("longfoo", []byte("DFo6Wc2jDhmA7Yt4PbHyh8RO4vVG7leOzK412gf2TXNPJhuCUs1rB29nkJJd4ICimZGpyWpMGalSvDxf")))
+			p.TestClaims.CreateOutput(r.NewOutput("porter-state", []byte("porter-state.tgz contents")))
 
 			opts := OutputListOptions{
 				sharedOptions: sharedOptions{