Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#243): Adds the rank question type - old #274

Closed
wants to merge 8 commits into from

Conversation

latin-panda
Copy link
Collaborator

Closes #243

WIP: Early development stage


I have verified this PR works in these browsers (latest versions):

  • Chrome
  • Firefox
  • Safari (macOS)
  • Safari (iOS)
  • Not applicable

What else has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Do we need any specific form for testing your changes? If so, please attach one.

What's changed

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: fa310f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…add-rank-component

# Conflicts:
#	packages/web-forms/src/components/FormQuestion.vue
#	packages/xforms-engine/src/client/hierarchy.ts
#	packages/xforms-engine/src/client/unsupported/UnsupportedControlNode.ts
#	packages/xforms-engine/src/index.ts
#	packages/xforms-engine/src/instance/children.ts
#	packages/xforms-engine/src/instance/hierarchy.ts
@latin-panda latin-panda changed the title feat(#243): Adds the rank question type feat(#243): Adds the rank question type - old Jan 22, 2025
@latin-panda
Copy link
Collaborator Author

Closing in favor of PR #288

This PR was originally forked and worked on while waiting for relevant PRs to be merged. During that time, it fell behind the main branch. Since PR #288 now covers the necessary changes, I’m closing this one in favor of the updated PR.

@latin-panda latin-panda deleted the add-rank-component branch January 22, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the rank question type
1 participant