Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release @getodk/web-forms 0.4.0 #220

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

sadiqkhoja
Copy link
Contributor

@sadiqkhoja sadiqkhoja commented Sep 19, 2024

What's changed

  • Ran changeset version command and updated description in changelog to removed trigger from Unsupported nodes
  • Fixed feature matrix rendering, it had become quite ugly
  • Updated feature matrix to mark trigger as WIP

Before:

After:

I have verified this PR works in these browsers (latest versions):

  • Chrome
  • Firefox
  • Safari (macOS)
  • Safari (iOS)
  • Not applicable

What else has been done to verify that this works as intended?

NA

Why is this the best possible solution? Were any other approaches considered?

I can move feature matrix rendering from this PR. I tried various things to fix alignment of the headings but nothing seems to work. I ended up added hard coded spacing between category heading and progress-bar (don't want to spend to much time here)

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

None

Do we need any specific form for testing your changes? If so, please attach one.

NA

Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 454b901

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

I think GitHub has updated its Latex functionality which has made our feature matrix rendering quite ugly.
I have tried various things to set the padding for category heading but nothing worked, ended up with hard coding it
it could well be mark as done but we haven't done any UI design work for this
@sadiqkhoja sadiqkhoja marked this pull request as ready for review September 19, 2024 18:24
Copy link
Member

@eyelidlessness eyelidlessness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd take a quick look at maybe simplifying the alignment. I suspect another unit besides mm might be computable. But I don't know LaTeX, and neither does preview in VSCode. So I'm gonna keep treating the feature matrix stuff as kind of a black box to me.

On Slack we discussed maybe paring down the complexity in the feature matrix. I'm looking forward to ideas on that.

Otherwise LGTM. Let's ship it! 🚀

@sadiqkhoja
Copy link
Contributor Author

Created #221 to iterate on feature-matrix in README

@sadiqkhoja sadiqkhoja merged commit 785cba6 into getodk:main Sep 19, 2024
43 checks passed
@sadiqkhoja sadiqkhoja deleted the chore/release-0_4_0 branch September 19, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants