Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Jackson #709

Closed
wants to merge 4 commits into from
Closed

Upgrade Jackson #709

wants to merge 4 commits into from

Conversation

seadowg
Copy link
Member

@seadowg seadowg commented Feb 21, 2023 •
edited
Loading

Upgrade Jackson to fix FasterXML/jackson-databind#3412

@seadowg seadowg marked this pull request as ready for review February 21, 2023 23:09
lognaturel
lognaturel previously approved these changes Feb 21, 2023
View reviewed changes
@lognaturel lognaturel dismissed their stale review February 22, 2023 00:05

Does not actually work

@lognaturel
Copy link
Member

lognaturel commented Feb 22, 2023 •
edited
Loading

Sigh, looks like your instinct to double check was right, @seadowg, this doesn't work. And actually now I see FasterXML/jackson-databind#3412 does not suggest it would. There was some additional use of getParameterCount() introduced in .2 and removed in .3. What it looks like to me is that before #707 (when we just parsed points), we avoided any functionality that resulted in that method being called. Now we use it. I can't yet spot the change. The only thing I can really think of is the change to List<Object>.

@seadowg seadowg closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lognaturel lognaturel lognaturel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 2.13.2 uses Method.getParameterCount() which is not supported on Android before API 26
2 participants
@seadowg @lognaturel