Add preventDefault + hack to avoid karma throwing some of your tests … #1129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047 and makes all test pass which are currently failing.
What has been done to verify that this works as intended?
All tests are passing and no file is created on the file system.
Why is this the best possible solution? Were any other approaches considered?
preventDefault
fixes #1047.Fix for failing test:
This is mysterious fix, I don't exactly know the root cause. The issue seems related to karma-runner/karma#3887 because when I ran only two tests in
data-template.spec.ts
, I saw this error "Some of your tests did a full page reload!".One suggestion over there is to add following:
So I added that and it worked. It didn't make sense to me so I removed the
onbeforeunload
, just keptbeforeEach(async () => {};
and it worked as well. That's what this PR contains.Alternative solution: #1122
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
npm run test
andnpm run lint
and confirmed all checks still pass OR confirm CircleCI build passes