Expose md5 hash of file attachments through api #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Nov 13, 2024
| left outer join (select id, md5 from blobs) as blobs on form_attachments."blobId"=blobs.id | ||
| where "formDefId"=${formDefId} order by name asc`) | ||
| .then(map(_unjoinMd5)) | ||
| .then(map(_chooseBlobHash)); | ||
|
|
||
| const getByFormDefIdAndName = (formDefId, name) => ({ maybeOne }) => maybeOne(sql` |
There was a problem hiding this comment.
Is there a test that hits this function? All the tests below seem to involve arrays of form attachments, which I'd guess hit getAllByFormDefId(), but not this function. How about adding a test of the /v1/projects/:projectId/forms/:id/attachments/:name endpoint that verifies that hash is added to the response?
There was a problem hiding this comment.
This endpoint returns the contents of the file, so it doesn't have the hash. This means that I might not need this particular unjoiner for getByFormDefIdAndName though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#758
Exposes the property
hashon form attachments, which is set to:md5hash value of the attachment blob fileUnlike the OpenRosa hash for the form manifest, this value is set to null for dataset attachments and doesn't change when a dataset has more entities added/updated.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
yes, need to add to docs.
Before submitting this PR, please make sure you have:
make testand confirmed all checks still pass OR confirm CircleCI build passes