Update Submissions OData to include deletedAt
#1231
+224
−554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of getodk/central#709
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
I have added
__system/deletedAt
field in the OData response and made it filterable. If client’s$filter
expression doesn’t contain__system/deletedAt
related clause then default__system/deletedAt eq null
is added.This approach keeps our Odata API consistent with respect to other system fields and quite useful for clients who are interested in filtering Submissions by deletedAt column. Maybe in future we also want to add this on the frontend.
Other option was to add a special filterable boolean field
__system/deleted
, which is simple but doesn't come with the benefits mentioned above.OData spec doesn’t have anything explicit mechanism to track deleted records. There is a concept of deltaLink that returns list of new/changed/deleted records since last request. That concept is not related to what are looking for here.
I have added a new function
odataExcludeDeleted
that analyzes$filter
expression for the existence of__system/deletedAt
related clause. Initially, I had modifiedodataFilter
function with the same logic but that made it convoluted, hence I refactored it into a separate function for the sake of simplicity at the cost of parsing$filter
expression twice.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
None.
Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.
Done.
Before submitting this PR, please make sure you have:
make test
and confirmed all checks still pass OR confirm CircleCI build passes