Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): Improve toast error messages #249

Closed
wants to merge 1 commit into from
Closed

Conversation

mtiller
Copy link

@mtiller mtiller commented Feb 3, 2022

This just modified the error handling on several axios calls
to extract the underlying error embedded in the HTTP response
so it is visible to the user.

Sorry for all the changes. The only real changes here are to the
toast calls. It appears that this project doesn't include
a .prettierrc file to standardize prettier settings. As s result, you'll
end up with this situation where all the files get formatted according
to different settings. You might want to consider adding a .prettierrc
file to ensure consistent formatting (at least among VS Code users).

This closes #244

This just modified the error handling on several `axios` calls
to extract the underlying error embedded in the HTTP response
so it is visible to the user.
@gempain
Copy link
Contributor

gempain commented Feb 3, 2022

Thanks so much for the changes ! Is there a way to rollback the changes made by prettier ? I would happily add a prettier config and also use it across the app, but I'd do this in another MR to avoid mixing things. Would you be able to configure a .prettierrc to automatically rollback the formatting changes ? If it's not possible I'll go through the review but there's indeed quite a lot of changes 😄

@mtiller
Copy link
Author

mtiller commented Feb 3, 2022

The problem is that I don't know what that .prettierrc should look like. I don't know what settings were used by all the contributors to meli. If we had such a .prettierrc file, all I'd need to do is resave all these files and push one more commit to the end of this branch. Do you know what editor was used for this and what formatting standards were followed?

@mtiller
Copy link
Author

mtiller commented Feb 4, 2022

I'll resubmit this without all the formatting changes. Just ignore this PR. I'll make a fresh one.

@mtiller mtiller closed this Feb 4, 2022
@gempain
Copy link
Contributor

gempain commented Feb 4, 2022

@mtiller don't worry I can still review 😄 Regarding the prettier file to use, all I ask for is:

  • 2 spaces indentation
  • single quotes
    I can setup a .prettierrc and provide it to you. Just need a bit of time.

@mtiller
Copy link
Author

mtiller commented Feb 4, 2022

There is now a much cleaner PR, #253.

@mtiller mtiller deleted the toast branch February 6, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants