Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎯 fix: Translation on some pages were not working due to wrong text-domains #2503

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/src/js/setup-wizard/commission/AdminCommission.vue
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
<template>
<div class="p-3">
<div class="mb-5">
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission type', 'dokan' )}}</p>
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission type', 'dokan-lite' )}}</p>
<div class="flex flex-col">
<select v-model="selectedCommission" id="_subscription_product_admin_commission_type" name="_subscription_product_admin_commission_type" class="select short">
<option v-for="(commissionData, key) in commissionTypes" :value="key">{{commissionData}}</option>
</select>
</div>
</div>
<div v-if="'category_based' === selectedCommission">
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission', 'dokan' )}}</p>
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission', 'dokan-lite' )}}</p>
<category-based-commission
:value="commission"
@change="onCategoryUpdate"
/>
</div>
<div v-else-if="'fixed' === selectedCommission">
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission', 'dokan' )}}</p>
<p class="!p-0 !m-0 !font-semibold" for="_subscription_product_admin_commission_type">{{__( 'Admin Commission', 'dokan-lite' )}}</p>
<combine-input
:value="fixedCommission"
v-on:change="fixedCOmmissionhandler"
Expand Down
2 changes: 1 addition & 1 deletion includes/Admin/WithdrawLogExporter.php
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
public function get_default_column_names() {
return apply_filters(
'dokan_withdraw_log_export_columns', [
'id' => __( 'ID', 'dokan' ),
'id' => __( 'ID', 'dokan-lite' ),
'vendor_id' => __( 'Vendor ID', 'dokan-lite' ),
'store_name' => __( 'Store Name', 'dokan-lite' ),
'amount' => __( 'Withdraw Total', 'dokan-lite' ),
Expand Down Expand Up @@ -199,26 +199,26 @@
$column_value = $withdraw_item['created'] ?? '';
break;

case "paypal_email":

Check failure on line 202 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "paypal_email" does not require double quotes; use single quotes instead
$column_value = $withdraw_item['details']['paypal']['email'] ?? '';
break;

case "skrill_email":

Check failure on line 206 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "skrill_email" does not require double quotes; use single quotes instead
$column_value = $withdraw_item['details']['skrill']['email'] ?? '';
break;

case "dokan_custom_method":

Check failure on line 210 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "dokan_custom_method" does not require double quotes; use single quotes instead
case "dokan_custom_value":

Check failure on line 211 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "dokan_custom_value" does not require double quotes; use single quotes instead
$field = substr_replace( $key, '', 0, 13 );
$column_value = $withdraw_item['details']['dokan_custom'][ $field ] ?? '';
break;

case "bank_ac_name":

Check failure on line 216 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_ac_name" does not require double quotes; use single quotes instead
case "bank_ac_number":

Check failure on line 217 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_ac_number" does not require double quotes; use single quotes instead
case "bank_ac_type":

Check failure on line 218 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_ac_type" does not require double quotes; use single quotes instead
case "bank_bank_name":

Check failure on line 219 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_bank_name" does not require double quotes; use single quotes instead
case "bank_bank_addr":

Check failure on line 220 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_bank_addr" does not require double quotes; use single quotes instead
case "bank_declaration":

Check failure on line 221 in includes/Admin/WithdrawLogExporter.php

View workflow job for this annotation

GitHub Actions / Run PHPCS inspection

String "bank_declaration" does not require double quotes; use single quotes instead
case "bank_iban":
case "bank_routing_number":
case "bank_swift":
Expand Down
4 changes: 2 additions & 2 deletions src/admin/components/AddReverseWithdraw.vue
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
:disabled="loading"
>
<img :src="loader" alt='' :class="loading ? 'is-loading' : 'not-loading'">
{{ __( 'Save', 'dokan' ) }}
{{ __( 'Save', 'dokan-lite' ) }}
</button>
</div>
</div>
Expand Down Expand Up @@ -350,7 +350,7 @@ export default {
paged: 1,
search: search
} ).done( ( response ) => {
self.allVendors = [ { vendorId: 0, store_name: self.__( 'Select vendor', 'dokan' ) } ].concat( response.map((item) => {
self.allVendors = [ { vendorId: 0, store_name: self.__( 'Select vendor', 'dokan-lite' ) } ].concat( response.map((item) => {
return {
vendorId: item.id,
store_name: item.store_name
Expand Down
4 changes: 2 additions & 2 deletions src/admin/pages/DummyData.vue
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export default {
let message = window.dokan_handle_ajax_error( jqXHR );
if ( message ) {
Swal.fire(
self.__( 'Something went wrong', 'dokan' ),
self.__( 'Something went wrong', 'dokan-lite' ),
message,
'error'
);
Expand Down Expand Up @@ -370,7 +370,7 @@ export default {
let message = window.dokan_handle_ajax_error( jqXHR );
if ( message ) {
Swal.fire(
self.__( 'Something went wrong', 'dokan' ),
self.__( 'Something went wrong', 'dokan-lite' ),
message,
'error'
);
Expand Down
Loading
Loading