Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: React Skeleton #2403
base: develop
Are you sure you want to change the base?
feat: React Skeleton #2403
Changes from 3 commits
a2701f5
e931d06
057a92f
0077f78
3d4d19c
9beb3b3
15994f8
c27f504
c295722
0b1ce02
25b4a1a
c56dacb
e59521e
e6bf1ec
8b2b753
a064fe7
322dc62
c9478eb
46bcda5
5f7ea35
16f8a1d
c8719b5
d045a63
44370c8
2585e5b
125f1b7
66f84ea
3e3ddd0
198afb2
8653afb
2efd5ef
bd36d1b
047c91b
0b2dece
754b010
b91b8dd
7a1c587
4692634
d695a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential typo in 'sidebar' color variable
In line 51, the
sidebar
color is set to'var(--dokan-button-background-color, #1B233B)'
. This seems inconsistent with the variable naming convention used elsewhere. Should it be'var(--dokan-sidebar-background-color, #1B233B)'
to match thesidebar
background color variable used in thebackgroundColor
section?Apply this diff to correct the variable name:
sidebar: 'var(--dokan-button-background-color, #1B233B)', + sidebar: 'var(--dokan-sidebar-background-color, #1B233B)',
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the variable name to match the asset being loaded
The variable
$frontend_shipping_asset
is assigned the contents offrontend.asset.php
. The name suggests it's related to shipping assets, which might be misleading in this context. To improve clarity and maintain consistent naming conventions, please rename the variable to$frontend_asset
.Apply this diff to correct the variable name:
Ensure to update all references to
$frontend_shipping_asset
accordingly.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls use
id
instead ofclass
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider enhancing the NotFound component for better user experience and maintainability.
While the current implementation is functional, consider the following improvements:
<main>
or<section>
.Here's an example of how you could improve the component:
Note: This assumes you're using React Router for navigation. If not, adjust the import and
Link
component accordingly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add to the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls add developer docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider enhancing type safety and documentation.
The Footer component looks good overall, but consider these enhancements:
Add TypeScript type annotations:
Add a JSDoc comment to describe the component's purpose and usage:
These changes would improve type safety and make the component's purpose clearer to other developers.
Would you like me to prepare a diff with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
title
docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Add proper error handling for wp.hooks access
The codebase shows better patterns for accessing wp.hooks. Replace the direct access with:
Or use the established pattern from Bootstrap.js:
This prevents runtime errors if wp.hooks is not available and removes the need for @ts-ignore.
🔗 Analysis chain
Consider adding error handling for wp.hooks.
The code assumes
wp.hooks
is always available, which might not be true in all environments (e.g., testing).Add error handling and run this script to verify wp.hooks usage across the codebase:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 70
Script:
Length of output: 78043
Script:
Length of output: 364
Script:
Length of output: 77284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve type safety and consistency in route definitions
The
getRoutes
function is well-structured and allows for extensibility through WordPress hooks. However, there are a couple of areas for improvement:TypeScript error suppression:
The use of
@ts-ignore
is hiding potential type issues. Instead, consider properly typing thewp.hooks.applyFilters
function.Inconsistent path definitions:
Some paths start with '/' while others don't, which can lead to routing inconsistencies.
To address these issues:
@ts-ignore
with proper typing:These changes will improve type safety and ensure consistent routing behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls extract the entries to the separate file