Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: React Skeleton #2403
base: develop
Are you sure you want to change the base?
feat: React Skeleton #2403
Changes from 33 commits
a2701f5
e931d06
057a92f
0077f78
3d4d19c
9beb3b3
15994f8
c27f504
c295722
0b1ce02
25b4a1a
c56dacb
e59521e
e6bf1ec
8b2b753
a064fe7
322dc62
c9478eb
46bcda5
5f7ea35
16f8a1d
c8719b5
d045a63
44370c8
2585e5b
125f1b7
66f84ea
3e3ddd0
198afb2
8653afb
2efd5ef
bd36d1b
047c91b
0b2dece
754b010
b91b8dd
7a1c587
4692634
d695a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will be the default color if the css variables are not declared/assigned.
CC: @shohag121 vai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential typo in 'sidebar' color variable
In line 51, the
sidebar
color is set to'var(--dokan-button-background-color, #1B233B)'
. This seems inconsistent with the variable naming convention used elsewhere. Should it be'var(--dokan-sidebar-background-color, #1B233B)'
to match thesidebar
background color variable used in thebackgroundColor
section?Apply this diff to correct the variable name:
sidebar: 'var(--dokan-button-background-color, #1B233B)', + sidebar: 'var(--dokan-sidebar-background-color, #1B233B)',
📝 Committable suggestion