🎯 fix: DB related PHPCS security issues #2271
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -94,6 +94,7 @@ public function update_vendor_balance( $withdraw ) { | |
| return; | ||
| } | ||
|
|
||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $balance_result = $wpdb->get_row( | ||
| $wpdb->prepare( | ||
| "select * from {$wpdb->dokan_vendor_balance} where trn_id = %d and trn_type = %s", | ||
|
|
@@ -129,6 +130,7 @@ public function update_vendor_balance( $withdraw ) { | |
| ] | ||
| ); | ||
| } | ||
| // phpcs:enable | ||
| } | ||
|
|
||
| /** | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -97,13 +97,15 @@ public function is_valid_approval_request( $args ) { | |
| public function is_valid_cancellation_request( $args ) { | ||
| global $wpdb; | ||
|
|
||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $result = $wpdb->get_row( | ||
| $wpdb->prepare( | ||
| "select * from {$wpdb->dokan_withdraw} where id = %d and status = %d", | ||
| $args['id'], | ||
| $this->get_status_code( 'pending' ) | ||
| ) | ||
| ); | ||
| // phpcs:enable | ||
|
|
||
| if ( ! empty( $result ) ) { | ||
| // permission: vendor -> only own && shop_manager | ||
|
|
@@ -135,6 +137,7 @@ public function update_status( $id, $user_id, $status ) { | |
| // 1 -> active | ||
| // 2 -> cancelled | ||
|
|
||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $updated = $wpdb->update( | ||
| $wpdb->dokan_withdraw, | ||
| [ | ||
|
|
@@ -152,6 +155,7 @@ public function update_status( $id, $user_id, $status ) { | |
| '%d', | ||
| ] | ||
| ); | ||
| // phpcs:enable | ||
|
|
||
| if ( $updated !== 1 ) { | ||
| return new WP_Error( 'dokan_withdraw_unable_to_update', __( 'Could not update withdraw status', 'dokan-lite' ) ); | ||
|
|
@@ -185,7 +189,7 @@ public function insert_withdraw( $args = [] ) { | |
|
|
||
| $format = [ '%d', '%f', '%s', '%d', '%s', '%s', '%s', '%s' ]; | ||
|
|
||
| $inserted = $wpdb->insert( $wpdb->dokan_withdraw, $data, $format ); // phpcs:ignore WordPress.DB.DirectDatabaseQuery.DirectQuery | ||
|
There was a problem hiding this comment. Tip Codebase Verification Potential Issue with Direct Database Insertion and Lack of Data Sanitization The
Please ensure that all data passed to the database is properly sanitized and validated. Analysis chainCheck for potential issues with direct database insertions. The method Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify data sanitization in `insert_withdraw` method.
# Test: Search for the method usage. Expect: Proper sanitization before data is passed.
rg --type php $'insert_withdraw'
Length of output: 113 Script: #!/bin/bash
# Description: Extract the full implementation of the `insert_withdraw` method to verify data sanitization.
# Searching for the full implementation of the `insert_withdraw` method in the PHP file.
ast-grep --lang php --pattern 'public function insert_withdraw($_) { $$$ }' includes/Withdraw/Manager.php
Length of output: 214 Script: #!/bin/bash
# Description: Extract the full implementation of the `insert_withdraw` method to verify data sanitization.
# Using ripgrep to search for the full implementation of the `insert_withdraw` method.
rg --context 20 'public function insert_withdraw' includes/Withdraw/Manager.php
Length of output: 1407 Script: #!/bin/bash
# Description: Search for all instances where `insert_withdraw` is called to verify data sanitization.
# Using ripgrep to find all invocations of the `insert_withdraw` method.
rg 'insert_withdraw\('
Length of output: 106 |
||
|
|
||
| if ( $inserted !== 1 ) { | ||
| return new WP_Error( 'dokan_withdraw_unable_to_insert', __( 'Could not add new withdraw approval request.', 'dokan-lite' ) ); | ||
|
|
@@ -219,6 +223,7 @@ public function has_pending_request( $user_id ) { | |
|
|
||
| $wpdb->dokan_withdraw = $wpdb->prefix . 'dokan_withdraw'; | ||
|
|
||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $status = $wpdb->get_results( | ||
| $wpdb->prepare( | ||
| "SELECT id | ||
|
|
@@ -227,6 +232,7 @@ public function has_pending_request( $user_id ) { | |
| $user_id | ||
| ) | ||
| ); | ||
| // phpcs:enable | ||
|
|
||
| if ( $status ) { | ||
| return true; | ||
|
|
@@ -256,9 +262,11 @@ public function get_withdraw_requests( $user_id = '', $status = 0, $limit = 10, | |
| if ( false === $result ) { | ||
| global $wpdb; | ||
| if ( empty( $user_id ) ) { | ||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $result = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$wpdb->dokan_withdraw} WHERE status = %d LIMIT %d, %d", $status, $offset, $limit ) ); | ||
| } else { | ||
| $result = $wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$wpdb->dokan_withdraw} WHERE user_id = %d AND status = %d ORDER BY id DESC LIMIT %d, %d", $user_id, $status, $offset, $limit ) ); | ||
| //phpcs:enable | ||
|
Comment on lines
+265
to
+269
There was a problem hiding this comment. Optimize the retrieval of withdrawal requests. The method + $cache_result = wp_cache_get($cache_key, $cache_group);
+ if (false !== $cache_result) {
+ return $cache_result;
+ }
- $result = $wpdb->get_results(...);
+ wp_cache_set($cache_key, $result, $cache_group);
|
||
| } | ||
|
|
||
| $result = array_map( | ||
|
|
@@ -398,12 +406,14 @@ public function get( $id ) { | |
| global $wpdb; | ||
|
|
||
| if ( ! is_array( $id ) ) { | ||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $result = $wpdb->get_row( | ||
| $wpdb->prepare( | ||
| "select * from {$wpdb->dokan_withdraw} where id = %d", | ||
| $id | ||
| ), ARRAY_A | ||
| ); | ||
| // phpcs:enable | ||
| } else { | ||
| $attributes = [ | ||
| 'id' => '%d', | ||
|
|
@@ -522,6 +532,7 @@ public function get_user_withdraw_summary( $user_id = '' ) { | |
| $user_id = dokan_get_current_user_id(); | ||
| } | ||
|
|
||
| // phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery, WordPress.DB.DirectDatabaseQuery.NoCaching | ||
| $results = $wpdb->get_row( | ||
| $wpdb->prepare( | ||
| "SELECT | ||
|
|
@@ -535,6 +546,7 @@ public function get_user_withdraw_summary( $user_id = '' ) { | |
| ), | ||
| ARRAY_A | ||
| ); | ||
| // phpcs:enable | ||
|
|
||
| $summary = [ | ||
| 'total' => ! empty( $results['total'] ) ? absint( $results['total'] ) : 0, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra empty lines.
Ensure there are no multiple consecutive empty lines within functions.
Committable suggestion
Tools
GitHub Check: Run PHPCS inspection