-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: admin can change product author from rest api #1913
Merged
shohag121
merged 13 commits into
getdokan:develop
from
shohag121:update/assign-update-product-author-from-rest-api
Apr 4, 2024
Merged
update: admin can change product author from rest api #1913
shohag121
merged 13 commits into
getdokan:develop
from
shohag121:update/assign-update-product-author-from-rest-api
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devAsadNur
reviewed
Jun 9, 2023
devAsadNur
approved these changes
Jun 9, 2023
devAsadNur
added
the
Needs: Dev Review
It requires a developer review and approval
label
Jun 9, 2023
devAsadNur
added
👍 Dev Review Done
and removed
Needs: Dev Review
It requires a developer review and approval
labels
Jun 9, 2023
shashwatahalder01
added
QA approved
This PR is approved by the QA team
QA In Progress
and removed
Needs: Testing
This requires further testing
QA approved
This PR is approved by the QA team
labels
Jun 9, 2023
@shohag121, Kindly merge develop |
This comment was marked as resolved.
This comment was marked as resolved.
shohag121
added
Needs: Testing
This requires further testing
and removed
Type: Bug
labels
Jun 22, 2023
This comment was marked as resolved.
This comment was marked as resolved.
shashwatahalder01
added
QA In Progress
and removed
Needs: Testing
This requires further testing
labels
Jul 4, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
shashwatahalder01
added
QA approved
This PR is approved by the QA team
Needs: Testing
This requires further testing
and removed
QA In Progress
QA approved
This PR is approved by the QA team
labels
Jul 10, 2023
@nurul-umbhiya needs a discussion on resolving merge conflicts. |
@shohag121 merge conflict has been fixed |
shashwatahalder01
added
QA In Progress
QA approved
This PR is approved by the QA team
and removed
Needs: Testing
This requires further testing
QA In Progress
labels
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Products]
QA approved
This PR is approved by the QA team
REST API
Upcoming Release
👍 Dev Review Done
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
post_author
check and updated author ifcurrent_user_can( 'manage_options' )
passes. Closes [Dokan API]: The admin is facing restrictions while creating and updating or trying to assign a product to a vendor. #1730 .How to test the changes in this Pull Request:
Changelog entry
update: admin can change product author from REST API
Previously,
product_author
was read-only property, now admin can changeproduct_author
for an existing product or create a new product for another author.PR Self Review Checklist:
FOR PR REVIEWER ONLY: