Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript definition file #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add TypeScript definition file #26

wants to merge 1 commit into from

Conversation

moshest
Copy link

@moshest moshest commented Dec 4, 2019

No description provided.

@t5unamie
Copy link

Anyone know when this will be merged in?

@paoesco
Copy link

paoesco commented May 20, 2020

Hello,
interested in that one too :)

@ruscon
Copy link

ruscon commented Jun 18, 2020

ping

@moshest
Copy link
Author

moshest commented Jun 18, 2020

Notice we should also add "types": "lib/index.d.js", to package.json file in order for this to works.

jmnsf
jmnsf suggested changes Jul 27, 2020
View reviewed changes
lib/index.d.ts

interface VerifyResult {
wellFormed: boolean;
validDomain: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
validDomain: boolean;
validDomain: boolean | null;

Will be null if verifyDomain is false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmnsf jmnsf jmnsf requested changes

@juanpabloceliz juanpabloceliz juanpabloceliz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@moshest @t5unamie @paoesco @ruscon @jmnsf @juanpabloceliz