Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back default support for parquet fix #315 #444

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Add back default support for parquet fix #315 #444

merged 2 commits into from
Jul 17, 2024

Conversation

chainsawriot
Copy link
Collaborator

No description provided.

@chainsawriot
Copy link
Collaborator Author

chainsawriot commented Jul 15, 2024

  • Benchmark the installation time in a blank state Rocker instance

@chainsawriot
Copy link
Collaborator Author

Ignore the reduction in code coverage.

@chainsawriot
Copy link
Collaborator Author

On r-devel

install.packages("remotes"); system("apt update; apt install curl zlib1g-dev -y"); system(remotes::system_requirements(package = "rio", os_release = "22.04", os = "ubuntu")); system.time(remotes::install_github("gesistsa/rio"))

@chainsawriot
Copy link
Collaborator Author

HEAD:

   user  system elapsed 
223.919 112.346 248.115 

@chainsawriot
Copy link
Collaborator Author

This branch

install.packages("remotes"); system("apt update; apt install curl zlib1g-dev -y"); system(remotes::system_requirements(package = "rio", os_release = "22.04", os = "ubuntu")); system.time(remotes::install_github("gesistsa/rio@parquet"))

@chainsawriot
Copy link
Collaborator Author

This branch:

   user  system elapsed 
266.667 118.731 269.934 

@chainsawriot chainsawriot changed the title Add back default support for parquet ref #315 Add back default support for parquet fix #315 Jul 17, 2024
@chainsawriot chainsawriot merged commit 88aa095 into main Jul 17, 2024
9 of 10 checks passed
@chainsawriot chainsawriot deleted the parquet branch July 17, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant