Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed else clutter fix #334 #360

Merged
merged 8 commits into from
Sep 11, 2023
Merged

removed else clutter fix #334 #360

merged 8 commits into from
Sep 11, 2023

Conversation

schochastics
Copy link
Member

No description provided.

@schochastics schochastics changed the title removed else clutter #334 removed else clutter fix #334 Sep 11, 2023
@schochastics schochastics marked this pull request as ready for review September 11, 2023 15:41
@schochastics
Copy link
Member Author

@chainsawriot except for arg_reconcile, I think I checked everything, but let me know if you think I missed something

@schochastics
Copy link
Member Author

maybe read_delim?

@chainsawriot
Copy link
Collaborator

arg_reconcile, read_delim and read.fwf2 are like the 3 final bosses. Probably I will attend to them when I work on the ... for real.

Thank you for the refactoring!

@chainsawriot chainsawriot merged commit 524b5e0 into gesistsa:main Sep 11, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schochastics @chainsawriot