Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zap openxlsx and use writexl instead, fix #310 #359

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Zap openxlsx and use writexl instead, fix #310 #359

merged 3 commits into from
Sep 11, 2023

Conversation

chainsawriot
Copy link
Collaborator

  • Introduce lifecycle (which is a dependency of tibble anyway) to implement the deprecation of import(readxl).

  • Remove the overwriting of existing sheets by using which.

Ref #343

But which is not yet mapped to col_names for export(). #326

@chainsawriot
Zap openxlsx and use writexl instead, fix #310
46f0f07 
* Introduce `lifecycle` (which is a dependency of `tibble` anyway) to
implement the deprecation of `import(readxl)`.

* Remove the overwriting of existing sheets by using `which`.

Ref #343

But `which` is not yet mapped to `col_names` for export(). #326
@chainsawriot
Add tests and update NEWS
a3eed73 
writexl is 4x the speed of openxlsx

system.time(export(nycflights13::flights, tempfile(fileext = ".xlsx")))
@chainsawriot
Add more tests [no ci]
2590c9d
@chainsawriot chainsawriot mentioned this pull request Sep 11, 2023
Closed
@chainsawriot chainsawriot marked this pull request as ready for review September 11, 2023 11:27
@chainsawriot chainsawriot merged commit 81bbf48 into main Sep 11, 2023
@chainsawriot chainsawriot deleted the writexl branch September 11, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chainsawriot