Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #303 #304

Closed
wants to merge 2 commits into from
Closed

fix #303 #304

wants to merge 2 commits into from

Conversation

chainsawriot
Copy link
Collaborator

@chainsawriot chainsawriot commented Aug 20, 2023 •
edited
Loading

Please ensure the following before submitting a PR:

  • if suggesting code changes or improvements, open an issue first
  • for all but trivial changes (e.g., typo fixes), add your name to DESCRIPTION
  • for all but trivial changes (e.g., typo fixes), documentation your change in NEWS.md with a parenthetical reference to the issue number being addressed
  • if changing documentation, edit files in /R not /man and run devtools::document() to update documentation
  • add code or new test files to /tests for any new functionality or bug fix
  • make sure R CMD check runs without error before submitting the PR

@chainsawriot
Copy link
Collaborator Author

@leeper Do you want me to update the GHA?

@chainsawriot
Copy link
Collaborator Author

BTW; saying this in 2023 is too much to ask

https://github.com/leeper/rio/blob/c17081c6c2892591998f494cc19ee2c2058ebcea/DESCRIPTION#L41

@chainsawriot chainsawriot closed this by deleting the head repository Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chainsawriot