Fix #435 (#441)

* Fix #435 * Integration test
gesistsa · Jul 11, 2024 · ff585e2 · ff585e2
1 parent 4071bec
commit ff585e2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/R/utils.R b/R/utils.R
@@ -103,6 +103,9 @@ escape_xml <- function(x, replacement = c("&amp;", "&quot;", "&lt;", "&gt;", "&a
     if (isFALSE(length(file) == 1) && single_only) {
         stop("Invalid `file` argument: `file` must be single", call. = FALSE)
     }
+    if (any(is.na(file))) {
+        stop("Invalid `file` argument: `file` must not be NA", call. = FALSE)
+    }
     invisible(NULL)
 }
 

diff --git a/tests/testthat/test_check_file.R b/tests/testthat/test_check_file.R
@@ -8,6 +8,10 @@ test_that(".check_file", {
     expect_error(.check_file(data))
     expect_error(.check_file(iris))
     expect_error(.check_file(c("a.csv", "b.csv")))
+    expect_error(.check_file(NA))
+    expect_error(.check_file(NA_character_))
+    expect_error(.check_file(c(NA, "a.csv")))
+    expect_error(.check_file(c(NA_character_, "a.csv")))
     expect_error(.check_file("a.csv"), NA)
     expect_error(.check_file(), NA)
     ## single_only FALSE

diff --git a/tests/testthat/test_compress.R b/tests/testthat/test_compress.R
@@ -137,3 +137,11 @@ test_that("Relative path #438", {
         expect_true(file.exists("arch/archive.zip"))
     })
 })
+
+test_that("Integration test #435", {
+    ## filter out all NA cases so that #437 works
+    withr::with_tempfile("iris_path", fileext = "csv.zip", code = {
+        expect_error(rio::export(iris, NA), "must be character") ## strange to be honest
+        expect_error(rio::export(iris, NA_character_), "must not be NA")
+    })
+})