add IIO_S3_AWS_FORCE_PATH_STYLE environment variable to support minio s3 server #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add environment variable to set the forcePathStyle s3 client property.
We use a minio s3 server as a storage backend for geotiffs in geoserver. It does not allow virtual hosts for bucket addressing in our configuration. Previously the aws s3 sdk did only default to virtual host style addressing when the hostname started with "s3.". This was recently changed I think, so now it always uses virtual host style bucket addressing. This MR would add an environment variable to force the underlying amazon aws s3 sdk to use path based addressing. A similar problem was mentioned in issue #223.
I would welcome any kind of feedback.