Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug/fix s3 range reader read header error #301

Closed
wants to merge 2 commits into from
Closed

Bug/fix s3 range reader read header error #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b57b96
Update unit test to identify problem
mhn17 Mar 12, 2024
50f750a
Fix missing path in S3RangeReader::getURL()
mhn17 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...g-rangereader-s3/src/main/java/it/geosolutions/imageioimpl/plugins/cog/S3RangeReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public URL getURL() throws MalformedURLException {
+ S3ConfigurationProperties.S3_DOT_VH
+ configProps.getRegion()
+ S3ConfigurationProperties.AMAZON_AWS
+ "/" + configProps.getFilename());
+ "/" + configProps.getKey());
}
return super.getURL();
}
Expand Down
2 changes: 2 additions & 0 deletions ...cog-rangereader-s3/src/test/java/it/geosolutions/imageio/cog/S3RangeReaderOnlineTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,11 @@ public void s3RangeGetURL() throws MalformedURLException {
//s3:// isn't recognized as a known protocol so a real URL can't be built on top of it.
//Let's check that we can get a valid URL anyway (translating it to http protocol).
URL url = reader.getURL();
BasicAuthURI uri = new BasicAuthURI(url);
S3ConfigurationProperties configurationProperties = new S3ConfigurationProperties(uri.getUri().getScheme(), uri);
assertEquals(region, configurationProperties.getRegion());
assertEquals(bucket, configurationProperties.getBucket());
assertEquals(file, configurationProperties.getKey());
}

@Test
Expand Down