-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting TCRS configuration through gridset selector #375
base: main
Are you sure you want to change the base?
Conversation
Code depends on this GeoTools PR adding PROJ formatting support: geosolutions-it/geotools#84 MapML XML/XSD has been updated to modify the projection elements. Side Question on the next task related to Projection support: The generated LayerPreview will use that CRS. Is it what is requested? |
That is ok! One thing I don't want to have happen is to allow the projection name string to contain
You are correct.
This is done, thanks! |
This is already addressed, there is also a note in the GridSet to TCRS Selector documentation that reports that: Quoting: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, see comments below
|
||
/** */ | ||
public MapMLGridsets() { | ||
gwc = GeoServerExtensions.bean(GWC.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a java bean, why isn't it injected through he constructor (or like before, using autowiring?)
src/extension/mapml/src/main/java/org/geoserver/mapml/gwc/gridset/MapMLGridsets.java
Show resolved
Hide resolved
src/extension/mapml/src/main/java/org/geoserver/mapml/tcrs/TiledCRSListInitializer.java
Show resolved
Hide resolved
src/extension/mapml/src/main/java/org/geoserver/mapml/tcrs/TiledCRSListInitializer.java
Show resolved
Hide resolved
src/extension/mapml/src/main/java/org/geoserver/mapml/tcrs/TiledCRSListInitializer.java
Show resolved
Hide resolved
TILED_CRS.put(name, tiledCRS); | ||
TILED_CRS.put(("MAPML:" + name).toUpperCase(), tiledCRS); | ||
if (code.toUpperCase().startsWith("EPSG:")) { | ||
String urnEPSGcode = code.replace("EPSG:", "URN:OGC:DEF:CRS:EPSG::"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And what if we want to use MapML on Mars or the Sun? (e.g., IAU authority)
src/extension/mapml/src/main/java/org/geoserver/mapml/web/MapMLTCRSSettingsPage.java
Show resolved
Hide resolved
src/extension/mapml/src/main/java/org/geoserver/mapml/MapMLFeatureUtil.java
Show resolved
Hide resolved
src/extension/mapml/src/main/java/org/geoserver/mapml/MapMLFeatureUtil.java
Show resolved
Hide resolved
|
||
@Test | ||
public void testGridsetToTiledCRS() throws Exception { | ||
CoordinateReferenceSystem crs = CRS.decode("MapML:UTM31WGS84Quad"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. I would also check that:
- The code shows up in "CRS.getSupportedCodes()
- A GUI test that adds a built-in valid griset as a valid TRCS, and after the submission, the CRS class can find it
Checklist
main
branch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket
.