Geos 11353 map ml default image format

[turingtestfail]

Checklist

• I have read the contribution guidelines.
• I have sent a Contribution Licence Agreement (not required for small changes, e.g., fixing typos in documentation).
• First PR targets the main branch (backports managed later; ignore for branch specific issues).
• All the build checks are green (see automated QA checks).

For core and extension modules:

• New unit tests have been added covering the changes.
• Documentation has been updated (if change is visible to end users).
• The REST API docs have been updated (when changing configuration objects or the REST controllers).
• There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
• Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
• Bug fixes and small new features are presented as a single commit.
• Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

[prushforth]

Looks like it saves the image setting so that it gets used in for example the WMS request dropdown, but the saved value isn't reflected in the UI when you go back into edit the layer to change it - it displays image/png always as far as I can tell.

I'll keep playing with it, let you know if I spot anything else. Thanks!

[turingtestfail]

Looks like it saves the image setting so that it gets used in for example the WMS request dropdown, but the saved value isn't reflected in the UI when you go back into edit the layer to change it - it displays image/png always as far as I can tell.

I'll keep playing with it, let you know if I spot anything else. Thanks!

Thanks - looks like default call was overwritting model value. It is removed and is working now.

[prushforth]

Thanks - looks like default call was overwritting model value. It is removed and is working now.

Yep, that is saving and working fine.

I noticed that the preview text/html; subtype=mapml is not using the saved mime type:

...

...

...

...
, but the raw WMS request from the dropdown list of formats will generate a mapml document that does use the saved mime type:

(but it's not in the parameters of the generated link):

...

but is in the templated link in the mapml document:

I would have thought that the selected default should get put into the preview via parameters?

[turingtestfail]

Thanks - looks like default call was overwritting model value. It is removed and is working now.

Yep, that is saving and working fine.

I noticed that the preview text/html; subtype=mapml is not using the saved mime type: ... ... ... ... , but the raw WMS request from the dropdown list of formats will generate a mapml document that does use the saved mime type:

(but it's not in the parameters of the generated link):

...

but is in the templated link in the mapml document:

I would have thought that the selected default should get put into the preview via parameters?

@prushforth Just made a push that makes sure that the HTML preview gets passed the layer setting.

[prushforth]

@prushforth Just made a push that makes sure that the HTML preview gets passed the layer setting.

Working very well now, thanks! I like the way it prevents changes to the default image media type while the layer is set to "Use Features". Also confirm that it works for Layer Groups.

Looks Good To Me! tm

[prushforth]

@turingtestfail has this one been merged upstream? I just noticed that you requested my review some time ago, but I thought it had been merged a while back?

[aaime]

It has indeed been merged upstream: geoserver#7612
Closing here.