Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEOS-11322] MapML WMS Vector Representation include query filter #361

Conversation

turingtestfail
Copy link

wildcard import removed

abstract parent needs the mime

file license

cleanup

fixed test issues with projection

validating sld filters

added getStyleQuery test

Moved to util class

cleanup

test fix

removed unnecessary inheritance

cleanup

pr response

PR responses and fix to resource vs layer metadata issue

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

@turingtestfail turingtestfail changed the title [GEOS-11294b] mapml wms vector representation query filter [GEOS-11322] MapML WMS Vector Representation include query filter Mar 5, 2024
@turingtestfail turingtestfail force-pushed the GEOS-11322-MapML-WMS-Vector-Query-Filter branch from 34025bb to d3264e0 Compare March 5, 2024 20:03
@turingtestfail turingtestfail force-pushed the GEOS-11322-MapML-WMS-Vector-Query-Filter branch 2 times, most recently from c0e545e to 0f13cdf Compare March 6, 2024 18:51
@prushforth
Copy link
Collaborator

I think it looks good. I was able to mix tile, image and features in a single request, and unsetting the global WMS checkbox reverted to a single image query. Nicely done, and thank you! I will document it tomorrow or Friday.

@turingtestfail turingtestfail force-pushed the GEOS-11322-MapML-WMS-Vector-Query-Filter branch 3 times, most recently from 194f8e4 to ad5c526 Compare March 11, 2024 19:22
wildcard import removed

abstract parent needs the mime

file license

cleanup

fixed test issues with projection

validating sld filters

added getStyleQuery test

Moved to util class

cleanup

test fix

removed unnecessary inheritance

cleanup

pr response

PR responses and fix to resource vs layer metadata issue

html version now adds feature kv

html source link should return mapml not features

added cql-filter test to sld filter test

switched to allowing mixed raster and vector based on layer settings

added check for mixed vector, raster in different extents

cleanup

added change to all layers vector documentation
@turingtestfail turingtestfail force-pushed the GEOS-11322-MapML-WMS-Vector-Query-Filter branch from ad5c526 to 78c2046 Compare March 12, 2024 13:26
@prushforth
Copy link
Collaborator

If I merge this PR with the commits in this PR, will I be able to evaluate SLD application to MapML vector requests? Or maybe this PR already has code that allows features to be requested (but not clipped)? Thanks

@prushforth
Copy link
Collaborator

Anyway, looks good to me!

Copy link
Collaborator

@prushforth prushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to add a note to the docs regarding single/multiple extent processing with mixed content types for each layer. Is it too late to do that?

Edit: I just pushed a commit with that documentation update.

@aaime
Copy link
Member

aaime commented Mar 14, 2024

Merged on main repository

@aaime aaime closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants