Geos 11294b map ml wms vector representation query filter #359
Conversation
useFeatures UI test added usefeatures to builder Return features links started on conversion First pass at building features clarify multi error cleanup
turingtestfail
force-pushed
the
GEOS-11294b-MapML-WMS-Vector-Representation-query-filter
branch
from
7eeb165
to
577a75f
Compare
| @@ -355,6 +355,7 @@ private MapMLLayerMetadata layersToOneMapMLLayerMetadata(List<RawLayer> layers) | |||
| MapMLLayerMetadata mapMLLayerMetadata = new MapMLLayerMetadata(); | |||
| mapMLLayerMetadata.setLayerMeta(new MetadataMap()); | |||
| mapMLLayerMetadata.setUseTiles(false); | |||
| useFeaturesAllLayers = allLayersUsingFeatures(layers); | |||
There was a problem hiding this comment.
I believe this one was meant to be gone, or not?
| WMSMapContent mapContent, | ||
| GeoServer geoServer, | ||
| HttpServletRequest httpServletRequest, | ||
| List<Query> queries) { |
There was a problem hiding this comment.
Since the builder supports a single layer I'd recommend simplifying things, and getting a single Query object here, eventually null.
| ds.addFeature( | ||
| feature( | ||
| polyType, | ||
| "polygon1", | ||
| "123 Main Street", | ||
| 1000, | ||
| "POLYGON ((1 1, 2 2, 3 3, 4 4, 1 1))")); | ||
| ds.addFeature( | ||
| feature( | ||
| polyType, | ||
| "polygon2", | ||
| "95 Penny Lane", | ||
| 2000, | ||
| "POLYGON ((6 6, 7 7, 8 8, 9 9, 6 6))")); | ||
| ds.addFeature( | ||
| feature( | ||
| polyType, | ||
| "polygon3", | ||
| "154 Sesame Street", | ||
| 3000, | ||
| "POLYGON ((11 11, 12 12, 13 13, 14 14, 11 11))")); | ||
| ReferencedEnvelope mapBounds = | ||
| new ReferencedEnvelope( | ||
| 0, 0.005, 0, 0.005, CRS.decode("urn:x-ogc:def:crs:EPSG:4326")); | ||
| Rectangle renderingArea = new Rectangle(256, 256); |
There was a problem hiding this comment.
Given you're testing the query filter only, do you actually need to have features in the sample data source?
A DataUtilities.store(new EmptyFeatureColection(targetType))might work as well.
| /** | ||
| * This is a simple class that contains the information needed to render a layer. | ||
| * | ||
| * <p>Basically, for a SLD, you create one of these for each of the FeatureTypeStyles inside it. |
There was a problem hiding this comment.
I would make it clear this is a copy of GeoTools code that is here to support building queries for rendering in formats that are not using StreamingRenderer.
| * Utility class for creating a query selecting those features relevant to the style and extent of | ||
| * the given map, for the given layer. |
There was a problem hiding this comment.
I'd make it clear here too, that some of the same code is available buried somewhere down in GeoTools.
Also make it clear that unlike GeoTools, the query does not contain a selection of properties, because the usage points need to dump all properties (vector tiles use case) and indicate the current consumers are mapml and vector tiles.
Checklist
mainbranch (backports managed later; ignore for branch specific issues).For core and extension modules:
[GEOS-XYZWV] Title of the Jira ticket.