Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker/jetty - removes javax.mail library provided by the docker imag… #294

Merged

Conversation

pmauduit
Copy link
Member

@pmauduit pmauduit commented Apr 24, 2024

…e (georchestra/georchestra#4233)

See georchestra/georchestra#4233 for the context ; applying the same fix as the one on the console docker image.

geOrchestra/geonetwork checklist

  • PR only involves cherry-picked commits from upstream.
  • PR contains custom code which will soon be available in an upstream release and can be overriden => mention core-geonetwork version if possible.
  • PR contains custom geOrchestra code, which need to be verified during future migrations.

georchestra/georchestra#4233)

See georchestra/georchestra#4233 for the
context ; applying the same fix as the one on the console docker image.
@pmauduit pmauduit requested a review from f-necas April 24, 2024 08:13
Copy link
Collaborator

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good for me even for documentation as it is mentionned here :
https://github.com/georchestra/geonetwork/blob/georchestra-gn4.2.x/georchestra-migration/migration-dev-guide.md?plain=1#L85

By the way, is it possible to change the link in the PR temlate which is broken by this one ? https://github.com/georchestra/geonetwork/blob/georchestra-gn4.2.x/georchestra-migration/migration-dev-guide.md

unrelated to current PR but attempt to fix url.
@pmauduit
Copy link
Member Author

By the way, is it possible to change the link in the PR temlate which is broken by this one ?

done

@pmauduit pmauduit merged commit df4dd8f into georchestra-gn4.2.x Apr 24, 2024
1 check passed
@pmauduit pmauduit deleted the docker-jetty-removes-javax-mail-lib-geor-4233 branch April 24, 2024 08:33
@pmauduit pmauduit restored the docker-jetty-removes-javax-mail-lib-geor-4233 branch April 24, 2024 08:40
Copy link

💔 All backports failed

Status Branch Result
georchestra-gn4.2.x-23.0.x Backport failed because of merge conflicts

You might need to backport the following PRs to georchestra-gn4.2.x-23.0.x:
- docker/jetty - removes javax.mail library provided by the docker image (georchestra/georchestra#4233)

Manual backport

To create the backport manually run:

backport --pr 294

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@pmauduit pmauduit deleted the docker-jetty-removes-javax-mail-lib-geor-4233 branch April 24, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants