remove entrypoint wait-for #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't we say that at first we would just provide the ability to disable the wait for instead of removing them entirely? |
|
No opinion here on whether to remove or disable. |
f-necas
force-pushed
the
georchestra-gn4.2.x
branch
from
4eb9b94
to
5dc598b
Compare
|
Now that, we wait for the database to be available through the new docker-compose features. |
|
cc @f-necas for your advice - no opinion on my side. |
|
@jeanmi151 I agree with the PR, sh scripts shouls be dropped |
|
will need to be backported to 23 |
|
@f-necas 23.0.7 |
f-necas
pushed a commit
that referenced
this pull request
Jun 7, 2024
* remove entrypoint wait-for * also remove wait for it script --------- Co-authored-by: Emilien Devos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: georchestra/georchestra#3938