Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeguard q parameter in template (#1037) #1038

Merged
merged 1 commit into from
Nov 2, 2024
Merged

safeguard q parameter in template (#1037) #1038

merged 1 commit into from
Nov 2, 2024

Conversation

tomkralidis
Copy link
Member

Overview

Fixes bug in #1037

Related Issue / Discussion

#1036

Additional Information

None

Contributions and Licensing

(as per https://github.com/geopython/pycsw/blob/master/CONTRIBUTING.rst#contributions-and-licensing)

  • I'd like to contribute [feature X|bugfix Y|docs|something else] to pycsw. I confirm that my contributions to pycsw will be compatible with the pycsw license guidelines at the time of contribution.
  • I have already previously agreed to the pycsw Contributions and Licensing Guidelines

@tomkralidis
Copy link
Member Author

FYI CI failure is unrelated.

@kalxas kalxas merged commit d4fa9aa into master Nov 2, 2024
2 of 4 checks passed
@kalxas kalxas deleted the fix-pr-1037 branch November 2, 2024 12:52
pvgenuchten
pvgenuchten reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@pvgenuchten pvgenuchten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if q is none…!
Sorry

@tomkralidis
Copy link
Member Author

@pvgenuchten all good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvgenuchten pvgenuchten pvgenuchten left review comments

@kalxas kalxas kalxas approved these changes

@ricardogsilva ricardogsilva Awaiting requested review from ricardogsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomkralidis @pvgenuchten @kalxas