API / Batch editing / On preview mode, return exception

[fxprunayre]

When using preview mode, no report or exception are returned and it is hard to track what is wrong. Improved error reporting in preview mode for:

• bad XPath in condition
• bad XML snippet.

Report exception directly.

Further work would be required for xpath in target element (failing in https://github.com/geonetwork/core-geonetwork/blob/main/core/src/main/java/org/fao/geonet/kernel/EditLib.java#L945)

Checklist

• I have read the contribution guidelines
• Pull request provided for main branch, backports managed with label
• Good housekeeping of code, cleaning up comments, tests, and documentation
• Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
• Clean commit messages, longer verbose messages are encouraged
• API Changes are identified in commit messages
• Testing provided for features or enhancements using automatic tests
• User documentation provided for new features or enhancements in manual
• Build documentation provided for development instructions in README.md files
• Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by Service Public de Wallonie

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[josegar74]

it seems invalid XPATH doesn't enter in the catch block, for example using (missing " in @xlink:href = https://metawal.wallonie.be:

/mdb:MD_Metadata/mdb:identificationInfo/*/mri:descriptiveKeywords[*/mri:thesaurusName/*/cit:title/gcx:Anchor/@xlink:href = https://metawal.wallonie.be/thesaurus/infrasig"]/*/mri:keyword/gco:CharacterString[. = 'Reporting INSPIRE']

[fxprunayre]

it seems invalid XPATH doesn't enter in the catch block, for example using (missing " in @xlink:href = https://metawal.wallonie.be:

Indeed for the target node expression. It fails in https://github.com/geonetwork/core-geonetwork/blob/main/core/src/main/java/org/fao/geonet/kernel/EditLib.java#L945. I'm less confident changing that part where we decompose the xpath. For this PR, I propose to only concentrate on bad XML snippet and condition xpath. Maybe an option would be to try trySelectNode before going into the update - what do you think ?

[josegar74]

Sounds good @fxprunayre. I'll test the items you describe that are handled

[josegar74]

@fxprunayre For me it's not really working with invalid snippet. With a service metadata (iso19115.3-2008):

• XPath: /mdb:MD_Metadata/mdb:identificationInfo/*/srv:serviceType[1]
• Snippet (see </co:ScopedName>):

<gco:ScopedName xmlns:gco="http://standards.iso.org/iso/19115/-3/gco/1.0" codeSpace="http://inspire.ec.europa.eu/metadata-codelist/SpatialDataServiceType">view
</co:ScopedName>

The preview doesn't fail and shows the following:

<srv:serviceType>&lt;gco:ScopedName xmlns:gco="http://standards.iso.org/iso/19115/-3/gco/1.0" codeSpace="http://inspire.ec.europa.eu/metadata-codelist/SpatialDataServiceType"&gt;view&lt;/co:ScopedName&gt;
</srv:serviceType>

[fxprunayre]

For me it's not really working with invalid snippet. With a service metadata (iso19115.3-2008):

The snippet is not really invalid, because the value can also be text. So in your test, as it is not detected as XML, it is considered as text in https://github.com/geonetwork/core-geonetwork/blob/main/core/src/main/java/org/fao/geonet/kernel/AddElemValue.java#L44 and it is properly inserted in the XML document as text.

[CLAassistant]

All committers have signed the CLA.