Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesaurus / Add support for codelist described using SDMX #7790

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

fxprunayre
Copy link
Member

SDMX is a common format used to statistical data and can be used to describe codelist. eg https://ec.europa.eu/eurostat/databrowser/bulk?lang=en&selectedTab=codeList

image

Add possibility to import those codelist as SKOS format.

Filename must use extension .sdmx.

Similar to #7674

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Funded by EEA

SDMX is a common format used to statistical data and can be used to
describe codelist. eg https://ec.europa.eu/eurostat/databrowser/bulk?lang=en&selectedTab=codeList

Add possibility to import those codelist as SKOS format.

Filename must use extension `.sdmx`.

Similar to #7674
@fxprunayre fxprunayre added this to the 4.4.3 milestone Feb 21, 2024
@fxprunayre fxprunayre requested a review from josegar74 February 21, 2024 10:20
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine.

For a future work, maybe to identify the file format we can do some checks on namespaces instead of relying on the file extension.

@fxprunayre
Copy link
Member Author

For a future work, maybe to identify the file format we can do some checks on namespaces instead of relying on the file extension.

Yes, I was thinking of this in case loading thesaurus from URL directly. I'll check in another PR.

@fxprunayre fxprunayre merged commit c3011e8 into main Feb 22, 2024
8 of 9 checks passed
@fxprunayre fxprunayre deleted the 44-sdmxcodelist branch February 22, 2024 08:40
fxprunayre added a commit that referenced this pull request May 23, 2024
In order to interact with the ESS Metadata Handler (https://cros.ec.europa.eu/book-page/technical-specifications-file-export-and-import-ess-metadata-handler), SDMX format can be used.

This formatter is quite specific to indicator provided to Eurostat (eg. https://ec.europa.eu/eurostat/cache/metadata/en/sdg_01_10_esmsip2.htm) and requires dedicated ISO19139 template and vocabularies (see EEA editor configuration for statistical datasets https://github.com/eea/geonetwork-eea/blob/eea-4.4.x/schemas/iso19139/src/main/plugin/iso19139/layout/config-editor.xml#L1667-L1727) but can serve as a basis for a more generic SDMX metadata export at some point.

Follow up of SDMX vocabulary support #7790

Funded by EEA
fxprunayre added a commit to eea/geonetwork-eea that referenced this pull request May 23, 2024
In order to interact with the ESS Metadata Handler (https://cros.ec.europa.eu/book-page/technical-specifications-file-export-and-import-ess-metadata-handler), SDMX format can be used.

This formatter is quite specific to indicator provided to Eurostat (eg. https://ec.europa.eu/eurostat/cache/metadata/en/sdg_01_10_esmsip2.htm) and requires dedicated ISO19139 template and vocabularies (see EEA editor configuration for statistical datasets https://github.com/eea/geonetwork-eea/blob/eea-4.4.x/schemas/iso19139/src/main/plugin/iso19139/layout/config-editor.xml#L1667-L1727) but can serve as a basis for a more generic SDMX metadata export at some point.

Follow up of SDMX vocabulary support geonetwork/core-geonetwork#7790

Funded by EEA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants