Update typescript definitions #791

hoetmaaiers · 2021-02-08T10:56:29Z

I have added my local typescript definitions to match the documation and my own usage. This is far from complete but just an update for my current project.

Referring: #790

The event system is harder to type and is added in comment. Any help is surely welcome.

Merge develop into Master Release 2.9.0

Update fa.json

Revert "Update fa.json"

Falke-Design · 2021-03-23T18:26:10Z

@hoetmaaiers can you please resolve the merge conflict and pull the newest develop version? We will create a release this week and it would be nice to have this PR in

Falke-Design

Maybe you want to update this changes but it is not necessary to merge this PR

Falke-Design · 2021-03-23T18:28:25Z

leaflet-geoman.d.ts

+      | 'Line'
+      | 'Rectangle'
+      | 'Polygon'
+      | 'Cut';


Please add CircleMarker
Is ImageOverlay missing here? They are only editable not drawable

Falke-Design · 2021-03-23T18:29:35Z

leaflet-geoman.d.ts

+
+    export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldrawmodetoggled';
+
+    export type GEOMAN_MAP_REMOVAL_MODE_EVENTS = 'pm:globalremovalmodetoggled';


globaldrawmodetoggled is missing

Falke-Design · 2021-03-23T18:30:45Z

leaflet-geoman.d.ts

+
+    export type GEOMAN_MAP_EDIT_MODE_EVENTS = 'pm:globaleditmodetoggled';
+
+    export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldrawmodetoggled';


Suggested change

export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldrawmodetoggled';

export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldragmodetoggled';

Falke-Design · 2021-03-23T18:33:40Z

leaflet-geoman.d.ts

+    export type GEOMAN_LAYER_EDIT_MODE_EVENTS =
+      | 'pm:edit'
+      | 'pm:vertexadded'
+      | 'pm:vertexremoved'
+      | 'pm:markerdragstart'
+      | 'pm:markerdragend'
+      | 'pm:snap'
+      | 'pm:unsnap'
+      | 'pm:intersect'
+      | 'pm:centerplaced';


Falke-Design · 2021-03-23T18:36:08Z

leaflet-geoman.d.ts

+      | 'pm:dragend';
+
+    export type GEOMAN_LAYER_CUT_MODE_EVENTS = 'pm:cut';
+


https://github.com/geoman-io/leaflet-geoman/tree/develop#removal-mode
Removal Mode is missing pm:remove

Falke-Design · 2021-03-23T18:49:27Z

leaflet-geoman.d.ts

+    export class LayerDrawOptions {
+      snappable?: boolean;
+      snapDistance?: number;
+      allowSelfIntersection?: boolean;
+      preventMarkerRemoval?: boolean;


Suggested change

export class LayerDrawOptions {

snappable?: boolean;

snapDistance?: number;

allowSelfIntersection?: boolean;

preventMarkerRemoval?: boolean;

export class LayerDrawOptions {

snappable?: boolean;

snapDistance?: number;

allowSelfIntersection?: boolean;

allowSelfIntersectionEdit?: boolean;

preventMarkerRemoval?: boolean;

removeLayerBelowMinVertexCount?: boolean;

limitMarkersToCount?: number;

limitMarkersToZoom?: number;

limitMarkersToViewport?: boolean;

limitMarkersToClick?: boolean;

pinning?: boolean;

Maybe this should named EditOptions because it is for edit mode

Falke-Design · 2021-03-23T18:52:24Z

leaflet-geoman.d.ts

+        lang:
+          | 'en'
+          | 'de'
+          | 'it'
+          | 'ru'
+          | 'ro'
+          | 'es'
+          | 'fr'
+          | 'pt_br'
+          | 'zh'
+          | 'nl',


Suggested change

lang:

| 'en'

| 'de'

| 'it'

| 'ru'

| 'ro'

| 'es'

| 'fr'

| 'pt_br'

| 'zh'

| 'nl',

lang:

| 'da'

| 'de'

| 'el'

| 'en'

| 'es'

| 'fa'

| 'fr'

| 'hu'

| 'id'

| 'it'

| 'nl'

| 'no'

| 'pl'

| 'pt_br'

| 'ro'

| 'ru'

| 'sv'

| 'tr'

| 'ua'

| 'zh'

| 'zh_tw';

Falke-Design · 2021-03-23T18:53:42Z

leaflet-geoman.d.ts

+      | 'pm:dragend';
+
+    export type GEOMAN_LAYER_CUT_MODE_EVENTS = 'pm:cut';
+


pm:langchange is missing
https://github.com/geoman-io/leaflet-geoman/tree/develop#customize-language

Falke-Design · 2021-03-23T18:54:09Z

leaflet-geoman.d.ts

+      | 'pm:dragend';
+
+    export type GEOMAN_LAYER_CUT_MODE_EVENTS = 'pm:cut';
+


pm:buttonclick and pm:actionclick are missing
https://github.com/geoman-io/leaflet-geoman/tree/develop#actions

Falke-Design · 2021-03-23T18:57:15Z

leaflet-geoman.d.ts

+    export class DrawControlOptions {
+      position?: ControlPosition;
+      drawMarker?: boolean;
+      drawCircleMarker?: boolean;
+      drawPolyline?: boolean;
+      drawRectangle?: boolean;
+      drawPolygon?: boolean;
+      drawCircle?: boolean;
+      editMode?: boolean;
+      dragMode?: boolean;
+      cutPolygon?: boolean;
+      removalMode?: boolean;


updated in current develop version

Falke-Design · 2021-03-23T20:14:30Z

leaflet-geoman.d.ts

-    interface LayerOptions {
-        pmIgnore?: boolean
+    interface Map {
+      addControls(options?: DrawControlOptions): void;


controlsVisible()

globalCutModeEnabled

enableGlobalCutMode

toggleGlobalCutMode

disableGlobalCutMode

globalEditModeEnabled

enableGlobalDragMode

disableGlobalDragMode

globalDragModeEnabled

toggleGlobalDragMode

enableGlobalRemovalMode

disableGlobalRemovalMode

globalRemovalModeEnabled

toggleGlobalRemovalMode

#821

Falke-Design · 2021-03-23T20:17:16Z

leaflet-geoman.d.ts

+
+  interface MapOptions {
+    pmIgnore?: boolean;
+  }


Interface PM

reInitLayer()

setOptIn

codeofsumit · 2021-03-29T18:27:35Z

Closing this one in favor of #825

codeofsumit and others added 6 commits January 5, 2021 16:21

Merge pull request geoman-io#746 from geoman-io/develop

7cdb0ed

Merge develop into Master Release 2.9.0

Update fa.json

8937f8d

Update FA language (patch)

04c85a3

Update fa.json

Revert "Update fa.json"

4787b4e

Merge pull request geoman-io#788 from geoman-io/revert-748-patch-3

2591108

Revert "Update fa.json"

Update typescript definitions

e14d7e6

Falke-Design changed the base branch from master to develop March 22, 2021 17:44

Falke-Design reviewed Mar 23, 2021

View reviewed changes

Falke-Design mentioned this pull request Mar 26, 2021

Typescript implementation #790

Open

ryan-morris mentioned this pull request Mar 26, 2021

Update typescript definitions #825

Merged

codeofsumit closed this Mar 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update typescript definitions #791

Update typescript definitions #791

hoetmaaiers commented Feb 8, 2021

Falke-Design commented Mar 23, 2021

Falke-Design left a comment

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

Falke-Design Mar 23, 2021

codeofsumit commented Mar 29, 2021


		export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldrawmodetoggled';

		export type GEOMAN_MAP_REMOVAL_MODE_EVENTS = 'pm:globalremovalmodetoggled';


		export type GEOMAN_MAP_EDIT_MODE_EVENTS = 'pm:globaleditmodetoggled';

		export type GEOMAN_MAP_DRAG_MODE_EVENTS = 'pm:globaldrawmodetoggled';

		\| 'pm:dragend';

		export type GEOMAN_LAYER_CUT_MODE_EVENTS = 'pm:cut';

Update typescript definitions #791

Update typescript definitions #791

Conversation

hoetmaaiers commented Feb 8, 2021

Falke-Design commented Mar 23, 2021

Falke-Design left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codeofsumit commented Mar 29, 2021