Simplify some CI checks #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
from
a1a7b15 to
a645a7c
Compare
kylebarron
reviewed
Aug 13, 2024
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
from
a645a7c to
ec79ba4
Compare
gadomski
changed the title
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
from
13491b7 to
cd9603f
Compare
kylebarron
approved these changes
Aug 13, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
30
to
35
| echo "GDAL_HOME=$(pwd)/build/.pixi/envs/default" >> "$GITHUB_ENV" | ||
| echo "LD_LIBRARY_PATH=$(pwd)/build/.pixi/envs/default/lib" >> "$GITHUB_ENV" | ||
| echo "GEOS_LIB_DIR=$(pwd)/build/.pixi/envs/default/lib" >> "$GITHUB_ENV" | ||
| # TODO: infer from toml file/lockfile | ||
| echo "GEOS_VERSION=3.12.1" >> "$GITHUB_ENV" | ||
| echo "PKG_CONFIG_PATH=$(pwd)/build/.pixi/envs/default/lib/pkgconfig" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
I'm not sure but we may still need these environment variables so that the Rust build tooling knows where to find libraries. But maybe activate-environment: true will be sufficient
There was a problem hiding this comment.
yuuup ... we're in good ol' debug-by-push at the moment 🙄 :-)
I'm going to bet most of the stuff is set correctly by the environment, but we might need to suppliment.
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
from
cd9603f to
62c6f19
Compare
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
2 times, most recently
from
980c334 to
241c717
Compare
kylebarron
reviewed
Aug 13, 2024
Comment on lines
-129
to
-131
| echo "GDAL_HOME=$(pwd)/build/.pixi/envs/default" >> "$GITHUB_ENV" | ||
| echo "LD_LIBRARY_PATH=$(pwd)/build/.pixi/envs/default/lib" >> "$GITHUB_ENV" | ||
| echo "GEOS_LIB_DIR=$(pwd)/build/.pixi/envs/default/lib" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
I do think you probably need GDAL_HOME and GEOS_LIB_DIR manually set. And probably GEOS_VERSION as well
There was a problem hiding this comment.
Seems to be passing w/o them? Right now only failure is on the Python .so
gadomski
force-pushed
the
issues/697-ci-cleanup
branch
from
241c717 to
abcc4f5
Compare
kylebarron
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up touching the wasm and python workflows as well, mostly to make whitespace consistent and to remove the
--allflags from thecargocommands (only used for workspaces, and its deprecated).