-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-wireless/remotemouse: new package #247
Conversation
@stkw0 please review. This package is important - because when mouse dies - the smartphone can be used as a backup. |
I already left some comments last week... |
Where? |
As a review. Github changed the interface, so maybe it's a bit more hidden. For me it was shown as a small square to the right in the diff tab. |
Weird, I still can see it. In any case, the only problematic thing was the use of a fake version number. If upstream didn't provide a version number, I think it would be more honest and correct to use a timestamp. |
cc14270
to
c81041f
Compare
Done. |
Thanks. Could you add RESTRICT=mirror too? Given it's "all rights reserved" there is no explicit permission to redistribute distfiles. |
Also, why there is an executable file that is not a shell script under /etc? That's smells bad. Could that be located in /opt for example? |
Signed-off-by: Vitaly Zdanevich <[email protected]>
Done. |
Seems there are a lot of missing RDEPENDs
|
But this software already have these dependencies vendored? |
I started filling RDEPEND, finding packages through https://portagefilelist.de but it is a lot of dependencies, I feel that we do not need them - because this software already works for me without installing them. |
For example
Do I need to add to |
Yes. They seems to bundle the whole PyQt5 with all functionality enabled. Is there some test suite that allows to unbundle those libraries with a certain degree of security that it won't produce any runtime problems? As a personal opinion, you don't closed source software like this to control your computer mouse with your phone. You could use for example kdeconnect (already packaged in Gentoo), maybe that solves your problem easily than adding a new hard-to-maintain ebuild. |
No description provided.